Various fixes for the news UI.

Made the layout for the status container more comprehensive.
Added a spacer to the bottom of news article content.
Disabled tabbing between the landing and news containers.
This commit is contained in:
Daniel Scalzi 2018-05-10 05:48:55 -04:00
parent 848440ed1c
commit f0a66e7a02
No known key found for this signature in database
GPG Key ID: 5CA2F145B63535F9
3 changed files with 84 additions and 48 deletions

View File

@ -937,7 +937,7 @@ p {
/* News article status container (left). */
#newsStatusContainer {
width: 25%;
height: 100%;
height: calc(100% - 30px);
padding: 15px;
display: flex;
flex-direction: column;
@ -960,6 +960,7 @@ p {
color: white;
text-decoration: none;
transition: 0.25s ease;
outline: none;
}
#newsArticleTitle:hover,
#newsArticleTitle:focus {
@ -1009,6 +1010,7 @@ p {
font-family: 'Avenir Book';
text-decoration: none;
transition: 0.25s ease;
outline: none;
}
#newsArticleComments:focus,
#newsArticleComments:hover {
@ -1043,6 +1045,7 @@ p {
#newsArticleContentScrollable a {
color: rgba(202, 202, 202, 0.75);
transition: 0.25s ease;
outline: none;
}
#newsArticleContentScrollable a:hover,
#newsArticleContentScrollable a:focus {
@ -1062,12 +1065,17 @@ p {
box-shadow: inset 0 0 10px rgba(255, 255, 255, 0.50);
}
/* Div to add spacing at the end of a news article. */
.newsArticleSpacer {
height: 30px;
}
/* News navigation container. */
#newsNavigationContainer {
display: flex;
justify-content: center;
align-items: center;
margin-bottom: 40px;
margin-bottom: 10px;
}
/* Navigation status span. */

View File

@ -731,6 +731,14 @@ function slide_(up){
// Bind news button.
document.getElementById('newsButton').onclick = () => {
// Toggle tabbing.
if(newsActive){
$("#landingContainer *").removeAttr('tabindex')
$("#newsContainer *").attr('tabindex', '-1')
} else {
$("#landingContainer *").attr('tabindex', '-1')
$("#newsContainer, #newsContainer *").removeAttr('tabindex')
}
slide_(!newsActive)
newsActive = !newsActive
}
@ -777,28 +785,35 @@ newsErrorRetry.onclick = () => {
/**
* Reload the news without restarting.
*
* @returns {Promise.<void>} A promise which resolves when the news
* content has finished loading and transitioning.
*/
async function reloadNews(){
function reloadNews(){
return new Promise((resolve, reject) => {
$('#newsContent').fadeOut(250, () => {
$('#newsErrorLoading').fadeIn(250)
initNews().then(() => {
resolve()
})
})
})
await initNews()
}
/**
* Initialize News UI. This will load the news and prepare
* the UI accordingly.
*
* @returns {Promise.<void>} A promise which resolves when the news
* content has finished loading and transitioning.
*/
async function initNews(){
function initNews(){
return new Promise((resolve, reject) => {
setNewsLoading(true)
let news = {}
try {
news = await loadNews()
} catch (err) {
// Empty
}
loadNews().then(news => {
newsArr = news.articles || null
@ -807,24 +822,23 @@ async function initNews(){
setNewsLoading(false)
$('#newsErrorLoading').fadeOut(250, () => {
$('#newsErrorFailed').fadeIn(250)
$('#newsErrorFailed').fadeIn(250, () => {
resolve()
})
})
} else if(newsArr.length === 0) {
// No News Articles
setNewsLoading(false)
$('#newsErrorLoading').fadeOut(250, () => {
$('#newsErrorNone').fadeIn(250)
$('#newsErrorNone').fadeIn(250, () => {
resolve()
})
})
} else {
// Success
setNewsLoading(false)
$('#newsErrorContainer').fadeOut(250, () => {
displayArticle(newsArr[0], 1)
$('#newsContent').fadeIn(250)
})
const switchHandler = (forward) => {
let cArt = parseInt(newsContent.getAttribute('article'))
let nxtArt = forward ? (cArt >= newsArr.length-1 ? 0 : cArt + 1) : (cArt <= 0 ? newsArr.length-1 : cArt - 1)
@ -834,7 +848,18 @@ async function initNews(){
document.getElementById('newsNavigateRight').onclick = () => { switchHandler(true) }
document.getElementById('newsNavigateLeft').onclick = () => { switchHandler(false) }
$('#newsErrorContainer').fadeOut(250, () => {
displayArticle(newsArr[0], 1)
$('#newsContent').fadeIn(250, () => {
resolve()
})
})
}
})
})
}
/**
@ -850,7 +875,7 @@ function displayArticle(articleObject, index){
newsArticleDate.innerHTML = articleObject.date
newsArticleComments.innerHTML = articleObject.comments
newsArticleComments.href = articleObject.commentsLink
newsArticleContent.innerHTML = articleObject.content
newsArticleContent.innerHTML = articleObject.content + '<div class="newsArticleSpacer"></div>'
newsNavigationStatus.innerHTML = index + ' of ' + newsArr.length
newsContent.setAttribute('article', index-1)
}

View File

@ -75,7 +75,10 @@ function showMainUI(){
}, 250)
}, 750)
initNews()
// Disable tabbing to the news container.
initNews().then(() => {
$("#newsContainer *").attr('tabindex', '-1')
})
}
function showFatalStartupError(){