From f472422281957d3241ad963127aaba2bdecfbac6 Mon Sep 17 00:00:00 2001
From: James Lyne <jim+github@not-null.co.uk>
Date: Sat, 26 Feb 2022 13:52:02 +0000
Subject: [PATCH] Move dynmap dimension guessing to util function

---
 src/util.ts        | 57 +++++++++++++++++++++++++++++++++++++++++++---
 src/util/dynmap.ts | 17 +++-----------
 2 files changed, 57 insertions(+), 17 deletions(-)

diff --git a/src/util.ts b/src/util.ts
index e9b3b40..ed5a73a 100644
--- a/src/util.ts
+++ b/src/util.ts
@@ -20,7 +20,7 @@ import LiveAtlasMapDefinition from "@/model/LiveAtlasMapDefinition";
 import {
 	Coordinate,
 	HeadQueueEntry,
-	LiveAtlasBounds,
+	LiveAtlasBounds, LiveAtlasDimension,
 	LiveAtlasGlobalMessageConfig,
 	LiveAtlasLocation,
 	LiveAtlasMessageConfig,
@@ -39,8 +39,8 @@ const documentRange = document.createRange(),
 	headQueue: HeadQueueEntry[] = [];
 
 export const titleColoursRegex = /§[0-9a-f]/ig;
-export const netherWorldNameRegex = /_?nether(_|$)/i;
-export const endWorldNameRegex = /(^|_)end(_|$)/i;
+export const netherWorldNameRegex = /[_\s]?nether([\s_]|$)/i;
+export const endWorldNameRegex = /(^|[_\s])end([\s_]|$)/i;
 
 export const getMinecraftTime = (serverTime: number) => {
 	const day = serverTime >= 0 && serverTime < 13700;
@@ -260,6 +260,14 @@ const _getMessages = (messageKeys: any, config: any = {}) => {
 	return messages as LiveAtlasGlobalMessageConfig;
 }
 
+/**
+ * Determines the bounds required to enclose the given separate arrays of x, y and z coordinates
+ * All arrays are expected to be the same length
+ * @param {number[]} x X coordinates
+ * @param {number[]} y Y coordinates
+ * @param {number[]} z Z coordinates
+ * @returns {LiveAtlasBounds} The calculated bounds
+ */
 export const getBounds = (x: number[], y: number[], z: number[]): LiveAtlasBounds => {
 	return {
 		min: {x: Math.min.apply(null, x), y: Math.min.apply(null, y), z: Math.min.apply(null, z)},
@@ -267,6 +275,12 @@ export const getBounds = (x: number[], y: number[], z: number[]): LiveAtlasBound
 	};
 }
 
+/**
+ * Determines the bounds required to enclose the given array of {@see Coordinate}s
+ * Multiple dimension arrays are accepted and will be handled recursively
+ * @param {Coordinate[]} points Points to determine the bounds for
+ * @returns {LiveAtlasBounds} The calculated bounds
+ */
 export const getBoundsFromPoints = (points: Coordinate[]): LiveAtlasBounds => {
 	const bounds = {
 		max: {x: -Infinity, y: -Infinity, z: -Infinity},
@@ -291,6 +305,11 @@ export const getBoundsFromPoints = (points: Coordinate[]): LiveAtlasBounds => {
 	return bounds;
 }
 
+/**
+ * Determines the center point of the given {@see LiveAtlasBounds}
+ * @param {LiveAtlasBounds} bounds The bounds to find the center point for
+ * @return {LiveAtlasLocation} The center point
+ */
 export const getMiddle = (bounds: LiveAtlasBounds): LiveAtlasLocation => {
 	return {
 		x: bounds.min.x + ((bounds.max.x - bounds.min.x) / 2),
@@ -299,6 +318,10 @@ export const getMiddle = (bounds: LiveAtlasBounds): LiveAtlasLocation => {
 	};
 }
 
+/**
+ * Creates an "allow-scripts" sandboxed <iframe> to be used by {@see runSandboxed}
+ * @returns {Window} The iframe's contentWindow
+ */
 const createIframeSandbox = () => {
 	const frame = document.createElement('iframe');
 	frame.hidden = true;
@@ -355,6 +378,14 @@ const sandboxWindow: Window | null = createIframeSandbox();
 const sandboxSuccessCallbacks: Map<number, (result?: any) => void> = new Map();
 const sandboxErrorCallbacks: Map<number, (reason?: any) => void> = new Map();
 
+/**
+ * Runs the given untrusted JavaScript code inside an "allow-scripts" sandboxed <iframe>
+ * The executing code cannot access or interfere with LiveAtlas state,
+ * but can still make requests and access many JS APIs
+ * @param {string} code The code to run
+ * @returns {Promise<any>} A promise that will resolve with the return value of the executed JS,
+ * or will reject with any Errors that occurred during execution.
+ */
 export const runSandboxed = async (code: string) => {
 	return new Promise((resolve, reject) => {
 		const key = Math.random();
@@ -368,3 +399,23 @@ export const runSandboxed = async (code: string) => {
 		}, '*');
 	});
 }
+
+/**
+ * Attempts to guess the dimension of the given world name
+ * The world name is checked against vanilla nether/end world names and regexes covering
+ * common nether/end world naming conventions
+ * If none of the above match, the world is assumed to be overworld
+ * @param {string} worldName Name of the world to guess
+ * @returns {LiveAtlasDimension} The guessed dimension
+ */
+export const guessWorldDimension = (worldName: string) => {
+	let dimension: LiveAtlasDimension = 'overworld';
+
+	if (netherWorldNameRegex.test(worldName) || (worldName == 'DIM-1')) {
+		dimension = 'nether';
+	} else if (endWorldNameRegex.test(worldName) || (worldName == 'DIM1')) {
+		dimension = 'end';
+	}
+
+	return dimension;
+}
diff --git a/src/util/dynmap.ts b/src/util/dynmap.ts
index 1134af5..b21fe77 100644
--- a/src/util/dynmap.ts
+++ b/src/util/dynmap.ts
@@ -23,7 +23,6 @@ import {
 	LiveAtlasChat,
 	LiveAtlasCircleMarker,
 	LiveAtlasComponentConfig,
-	LiveAtlasDimension,
 	LiveAtlasLineMarker, LiveAtlasMarker,
 	LiveAtlasPlayerImageSize,
 	LiveAtlasPointMarker,
@@ -33,10 +32,8 @@ import {
 } from "@/index";
 import {getPoints} from "@/util/areas";
 import {
-	decodeHTMLEntities,
-	endWorldNameRegex, getBounds, getImagePixelSize,
-	getMiddle,
-	netherWorldNameRegex,
+	decodeHTMLEntities, getBounds, getImagePixelSize,
+	getMiddle, guessWorldDimension,
 	stripHTML,
 	titleColoursRegex
 } from "@/util";
@@ -96,18 +93,10 @@ export function buildWorlds(response: Configuration, config: DynmapUrlConfig): A
 
 	//Get all the worlds first so we can handle append_to_world properly
 	(response.worlds || []).forEach((world: WorldConfiguration) => {
-		let worldType: LiveAtlasDimension = 'overworld';
-
-		if (netherWorldNameRegex.test(world.name) || (world.name == 'DIM-1')) {
-			worldType = 'nether';
-		} else if (endWorldNameRegex.test(world.name) || (world.name == 'DIM1')) {
-			worldType = 'end';
-		}
-
 		worlds.set(world.name, {
 			name: world.name,
 			displayName: world.title || '',
-			dimension: worldType,
+			dimension: guessWorldDimension(world.name),
 			seaLevel: world.sealevel || 64,
 			center: {
 				x: world.center.x || 0,