Add some missing <button> types

This commit is contained in:
James Lyne 2022-06-27 23:21:42 +01:00
parent 5d304606a6
commit 9fd9cec08a
2 changed files with 7 additions and 4 deletions

View File

@ -17,21 +17,24 @@
<template> <template>
<section class="sidebar" role="none" ref="sidebar"> <section class="sidebar" role="none" ref="sidebar">
<header class="sidebar__buttons"> <header class="sidebar__buttons">
<button ref="maps-button" v-if="mapCount > 1 || serverCount > 1" class="button--maps" data-section="maps" <button ref="maps-button" v-if="mapCount > 1 || serverCount > 1" type="button"
class="button--maps" data-section="maps"
:title="mapCount > 1 ? messageWorlds : messageServers" :title="mapCount > 1 ? messageWorlds : messageServers"
:aria-label="mapCount > 1 ? messageWorlds : messageServers" :aria-label="mapCount > 1 ? messageWorlds : messageServers"
:aria-expanded="mapsVisible" :aria-expanded="mapsVisible"
@click="handleSectionClick" @keydown="handleSectionKeydown"> @click="handleSectionClick" @keydown="handleSectionKeydown">
<SvgIcon ref="maps-icon" :name="mapCount > 1 ? 'maps' : 'servers'"></SvgIcon> <SvgIcon ref="maps-icon" :name="mapCount > 1 ? 'maps' : 'servers'"></SvgIcon>
</button> </button>
<button ref="markers-button" v-if="markerUIEnabled" class="button--markers" data-section="markers" <button ref="markers-button" v-if="markerUIEnabled" type="button"
class="button--markers" data-section="markers"
:title="messageMarkers" :title="messageMarkers"
:aria-label="messageMarkers" :aria-label="messageMarkers"
:aria-expanded="markersVisible" :aria-expanded="markersVisible"
@click="handleSectionClick" @keydown="handleSectionKeydown"> @click="handleSectionClick" @keydown="handleSectionKeydown">
<SvgIcon name="marker_point"></SvgIcon> <SvgIcon name="marker_point"></SvgIcon>
</button> </button>
<button ref="players-button" v-if="playerMakersEnabled" class="button--players" data-section="players" <button ref="players-button" v-if="playerMakersEnabled" type="button"
class="button--players" data-section="players"
:title="messagePlayers" :aria-label="messagePlayers" :aria-expanded="playersVisible" :title="messagePlayers" :aria-label="messagePlayers" :aria-expanded="playersVisible"
@click="handleSectionClick" @keydown="handleSectionKeydown"> @click="handleSectionClick" @keydown="handleSectionKeydown">
<SvgIcon name="players"></SvgIcon> <SvgIcon name="players"></SvgIcon>

View File

@ -27,7 +27,7 @@
<template v-else> <template v-else>
<div ref="subHeader" class="markers__header"> <div ref="subHeader" class="markers__header">
<button ref="backButton" class="markers__back" @click.prevent="currentSet = undefined"> <button type="button" ref="backButton" class="markers__back" @click.prevent="currentSet = undefined">
<SvgIcon name="arrow"></SvgIcon> <SvgIcon name="arrow"></SvgIcon>
</button> </button>
<h3 class="markers__set">{{ currentSet.label }}</h3> <h3 class="markers__set">{{ currentSet.label }}</h3>