From 2598f1794e7f0f3721e1d213559a84c368c78996 Mon Sep 17 00:00:00 2001
From: James Lyne <jim+github@not-null.co.uk>
Date: Tue, 20 Jul 2021 16:32:10 +0100
Subject: [PATCH] Hidden player fixes

- Don't apply other-world class for hidden players
- Use opacity instead of grayscale for player name to preserve colours (Fixes #40)
---
 src/components/sidebar/PlayerListItem.vue | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/src/components/sidebar/PlayerListItem.vue b/src/components/sidebar/PlayerListItem.vue
index 2d4acdf..163d7fc 100644
--- a/src/components/sidebar/PlayerListItem.vue
+++ b/src/components/sidebar/PlayerListItem.vue
@@ -45,6 +45,7 @@ export default defineComponent({
 		const store = useStore(),
 			otherWorld = computed(() => {
 				return store.state.configuration.grayHiddenPlayers
+					&& !props.player.hidden
 					&& (!store.state.currentWorld || store.state.currentWorld.name !== props.player.location.world);
 			}),
 
@@ -127,24 +128,20 @@ export default defineComponent({
 			padding-left: 2.7rem;
 		}
 
+		&.player--hidden:not(:hover),
+		&.player--other-world:not(:hover) {
+			.player__name {
+				opacity: 0.5;
+			}
+		}
+
 		&.player--hidden {
 			.player__icon {
 				filter: grayscale(1);
-				opacity: 0.5;
 			}
 		}
 
-		&.player--other-world:not(:hover) {
-			.player__icon {
-				opacity: 0.5;
-			}
-
-			.player__name {
-				color: var(--text-disabled);
-			}
-		}
-
-		&:hover, &:focus, &:active, &.player--other-world {
+		&:hover, &:focus, &:active {
 			.player__name ::v-deep(span) {
 				color: inherit !important;
 			}